From 56bcfc196f19d9667c5ae8f6dc40d7e32a59a00e Mon Sep 17 00:00:00 2001 From: Wei Gang Date: Wed, 26 Jan 2011 08:54:12 +0000 Subject: [PATCH] x86: Fix pirq teardown on domain destruction. The privilege check in unmap_domain_pirq() fails since the teardown completes in RCU (idle domain) context. We can remove the check since it is covered in physdev_op() already, which is the only potentially unprivileged caller. Signed-off-by: Wei Gang --- xen/arch/x86/irq.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index 11bd233794..3275b2d07c 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -1567,9 +1567,6 @@ int unmap_domain_pirq(struct domain *d, int pirq) if ( (pirq < 0) || (pirq >= d->nr_pirqs) ) return -EINVAL; - if ( !IS_PRIV_FOR(current->domain, d) ) - return -EINVAL; - ASSERT(spin_is_locked(&pcidevs_lock)); ASSERT(spin_is_locked(&d->event_lock)); -- 2.30.2